-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] base_comment_template: Search by model_ids.model #863
base: 16.0
Are you sure you want to change the base?
[FIX] base_comment_template: Search by model_ids.model #863
Conversation
The modified method comes from d9d2ef5 and 1f6bb66, maybe the authors @victoralmau and @AaronHForgeFlow would like to have a look? |
1c521f3
to
8e0edda
Compare
897e5b5
to
30f7241
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
30f7241
to
fb557a5
Compare
Rebased on |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
fb557a5
to
4e0c464
Compare
Rebased on |
How you do the searching? I tested in the comment template list and I can search by model successfully without this change. |
Thanks for having a look! self.env["base.comment.template"].search(
[
("model_ids.model", "=", user_model_name),
]
) as it's done in the added test; you can also check that the test fails without the other changes |
Sure, I just wanted to know if there was a way to test this as a user in Odoo. In any case as long as I can still search by model in the comment template list view in Odoo I am fine with this change. |
Just one thing, I think you can add yourself as contributor in the CONTRIBUTORS.rst file, but changing the copyright requires big changes on the module,I don't think thi sis the case. |
Right, thanks, I added myself to CONTRIBUTORS.
I usually add myself in any file I edit, no matter how big the change is; I believe it means these people agree with its copyright and even if I added only one line to this file I need to agree with its copyright. |
4e0c464
to
20cd8fb
Compare
I don't mind it. But there's some discussion is the OCA in regards that: https://github.com/orgs/OCA/discussions/185 Indeed the copyright lines does not mean much: https://github.com/orgs/OCA/discussions/185#discussioncomment-10656634 |
Steps:
Actual behavior:
Nothing is found
Expected behavior:
Comments for model your_model are found